-
-
Notifications
You must be signed in to change notification settings - Fork 387
London | 26-ITP-Jan | Shuheda Begum | Sprint 1 | Wireframe #956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Completed Wireframe with 100 accessibility score
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @codebyshay - your wireframe webpage looks very good! You have styled it nicely and made solid code changes within the files.
Here are a few adjustments that should be made (in addition to the comments I added in the code).
- The 'Read more' buttons should have an outline. You can refer to the exercise wireframe image for reference: https://github.com/CodeYourFuture/Module-Onboarding/blob/main/Wireframe/wireframe.png
- The footer should be fixed to the bottom of the page. This means that the footer should always be visible on the page. Here is a resource to review: https://www.w3schools.com/howto/howto_css_fixed_footer.asp
- Formatting you code within the IDE (VSCode, for example) can make your code easier to read for yourself and others. You can do this by right-clicking within a code file and choosing 'Format Document'.
Wireframe/index.html
Outdated
| <section class="grid"> | ||
| <article class="card"> | ||
| <div class="image"> | ||
| <img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAASAAAACvCAMAAABqzPMLAAAAnFBMVEX////q6uwAAADt7e+vrrG5ub3e3t7KyctpaGvv7++hoaPx8fP5+fmmpqd4eHyFholGRksjIizV1NWZmZthYmYAABE+PkSRkZUdHSXZ2tvk5OW0tbc5Oj++v8EAAA3Ozs9wcHRZWl4xMTcUFR6IiYwJChgsLDNQUVZ/f4I9PEQzNDqpqa5NTVEiIigQEht3dnwTEh9MSlMvLjgLDB7rC5A+AAAKSElEQVR4nO2diXaqvBpAQ5gHEYGKgBFwpGptT+/7v9tNQNTWIWBB0D97neWxpYGwyfAlRAGAwWAwGAwGg8FgMBgMBoPBYDAYDAaDwWAwGAwGg8FgMBiXEV3lhXHFPwvqwZemV4Og4M/76CxBLYKkGnLSUSQm6DZMEAUmiMLLCuIjuRSRens/LypIHpbvxlf2rT29pqAUpqWz5MfQubH5JQV5MKry5wgK1ze+oqAAIvKf92HJ5RIIsGiIDOP3troF8eQIEn4xyO/4VkLsvkVeXZOzd8SQ0TttZPhLjfJI278R1r9zXLcg0uIt41HAjeIPQxivzBvpjH8rUvsDUsDlX+2AD3X78CvpUAU+Y1OiDh7H5HS5BX6xiapPvQeQDERkiIGIbOdC+nlSvLPhaDT6mh4LUt2CEhsIcyCbcxHIKs7jiLueThMA8k2lN/bjRNZSpddzF0XO+nPBt7a26YausdUOGR6Hkje0kyRabhTXtz4v7n1BaliwJC9T8pKGkWNKKI4cGUWy4JwXa+GjeGcssKARPBaz2gX5oOeAKE6jaIx2AJwV2dN0AghlfL6ONB8jbwtWCdgWJmbx1nf8dAUsxdjaXpEksqeRkHL9jRe5TuQoF/c+CMnrB9akbPCbDTBFAaHeXEYy8lEknLeYzvDwdjsbjd76x021C+pr3EKbRv6gt9Q9t7+9lTCxBCFNOEswV7LguaGMq2W+BSuJUbIK5gkSkkQdFt5it89ZUqLYjqEovqJc7B2UmLxy0wVckYScJwNBAJrISUAI+UDSz1Ks0sPb8G02W5801XULshEy9BD/HIS4mEao0o7E1P1zZgDptvMawuvAGZdJIMFjM66qhhH82PZ63TywrMPbMt2osVSOPwzmQIX+8eeXFKTP1j79rwqiwWmV0kmlPNn6koKAocCp2S/F5wDeCkVeVBCuWlpcbk4+1m4EIuB1BdUGE0SBCaLABFFggigwQRSYIAp1C5KFl+A4FVmzIKO5NQSP5TD4qF2Qi8SnB7kNCjJ1XlX550Y3GxXESbqqcs8Kr+tNC9IX3ykix2n7XCvDq7oue0vUsKDgc41bOVfzn8sRvqSSEO8gnGlNVzFdtZ0VdjSey9jRU0jCdiJni/M89GRObVpQdjwuNJf4gIogdb4g8XoQmjNcdJRentnmBRFUnZezi2J5cncd4Utpawkp7n2Ei36ezccI4rJGLxDiEYS7WAi6JwnHIxxKcTl/S342mA8TlOUCFyTvH75EKyfqkiNcdPye+wbhNBUPRWfPQwXleZE2ygTCwedZXlqBJ9V/Ps6umn3hqj1aEMkSLkioT5Z9JZqttupIVXVfUHDRWZrhlXrfgiACKdSaC0mhbi2O5EkkaJGew4l4/Vq835KgPH88SluKI/HBcZeBi86I1mW0J4igFh3rsI8L0qNqWxYJrvaR4NWis6ddQXluOdEc4P5V2TwgjiRFRzQ/cLRR8nCtC9rnOr+kOI4kwpriUGDfcSRYsnvohCCuaBS+cIxPGoUGKlve5E2zvtNXy5fUrgjan0PerWy9G93KPZBOc0M6zW8SCVaqx10SxBVxJMwCk4pncnWXxPt8mEeC1b13TND5Cf3NUTaxQ4R/3Cu8e4L25+Vr5LzWlavEz73I3jarsjJ/78xvNwVx2RgJD6+/80a1uiPS6IdxNrHzt8mDzgrKzlI96ZYrzEfidHnY8D6X/1pJOy2I2wd26QjCRTHFR0uAS55IJnYm7qaOEUzXBRFO48jbQ4Ofc4K1dILPIIjL5yPDz5uDSyxHR/1xPotS35jlSQQRjtMTOI781Snlc4IkfkpFtdYR3RMJ4or7Vb8nuHD0J8+tfCa33gicezZBBDKxPX/P40g8psqULXDd+7w2J/g3nk8QdzLJjuPI4m5ShfFnJZ5SEEccGbo4nr3ByWzkcUZz80jPKYh0504CJ5Ph3N1Nftzoq5vnE0QmdsRsYsft4UiQxJF4RLFzG5qPfDJBh0hw3T/cDcmK036BBFe7oycSRG7xHe6n/axRKokjzVEWR9ZckLoq6Dya4aWNspssllcmQMiCp8ixdpMJmdg+23p3RjoqiA9Hg9/gAetsNluvl2dbCpbf76PZbPcGv35tGIl3G+qoIN2ZDK3aGE6c+3PSTUGqU+d3oQXQuXsA0l1BNX6kQXo9QXrdgox710d2UBC5t4rcegV93D292DVBvK5m62LeLgsy0I/vrNGPPxo32iwJTsnINosjq0rqlCBVVdE8jwT7FwUZa8ECfgRAIgLsRh9vlkAO/CGIfCklv5H9sy/9yU5M48TPJYRf1RfadkaQmt1T3eFgmMyFGZfboMgLNFnpI+AiF1lAxPkNnGlkcc4YeS5KHG14KRlug3Re53EcWX2hbTcEqSq/vyvv5Lm/0khzFvcueIIATN8ylsBPdFPoj4MkilehNzSsfuReEUR6sXyBxIgskMDXoOSdxPYF5dn+wM3OyXz8tW5eNmWgeQDYmmTaAKDYDjwHeL6n+Qj/JnBuCcp2rHOyN8wuRbmFti0Lygr+ftn/aX7vjIOkz4tfYvczDsoXSJCbrqQy06aRWhSUL/ZaZmvL/F8lvuFAkedxJEFuEU2ot4jaEpRN7JBJnPX80urEB0TSarbQdkHuFN26ydiGoCwSJOtbJ+616/eYoUZ+mxpn5M3d2Fcq28MFqdkdCXzhBufL/k+y5UA5qA0ZXh/N4+J7qyg/WBCu+vt7WtrtPkT36v3gskdZsR2Ex8bwZ7YeJ4hkY6OQdRpXl/2f4Jf7SqSy+LePdtKd/o4jHyQo+5zPMF/2Xyr8IEsRaqRM5HwIyCZkYrsoSA8QlC/2+sg+Kdb1jxxmcaR1Gkc2LQi3eyeRYAc+/kQlX/f5lQ8K1aY/Fh5ki70WSi2LvR5GFkfmC23DZgXhQTmcZou92j7nyuzXnjctSNJ8w1CfFd3geaNJQclG6/W052aTNCjoRWhKEPDLPayh6xy/6ZR9RRcFJogCE0SBCaLABFFggigwQRSYIApMEAUmiELHBanZv4tbDl+3alCeMfc3Oi4IymBx+QkQwSHf6F9TRyd0XdACfAfhdGV8GRbqOQC469QYWMJwLKSOZnwF1jSUE264vvEItb/RdUFC/O5DUXHMcJC6EQAigirkpIWBlMCSFUPUppGLhqjCg0aq0XVBwIU+jJCNvrXVAgB7aWNBQPoGyAXrJOrF4jpKDDG16Pu6j84L0mdBb7j2dRj0XfLUMHPA/w9IYyArQFsAtI6tSLHXW42+r/vouKD2YYIoMEEUmCAKTBAFJogCE0SBCaLABFFo89E1xbPzwgpp9reEjQpJwv1huAppuvHomv3DF+0qaXrFISuwf4iqWSVNFx5dA9NCUFo2jVY8GV6AWtnH0KSFoBSWzVnTj64pyVHQpmQaXT4Kksum6R0Flc1Z+5/2yTgK0kp+/JY/FVRydZ+uHQWVzdl/SpDKBN2GCaLABFFggigwQRSYIApMEAUmiAITRIEJosAEUWCCKDBBFJggCkwQBSaIwgME/R85IlXFrOHc9AAAAABJRU5ErkJggg==" alt="Article image" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The <img> src is very long and it makes your HTML hard to scan. Would it be possible for you to download the image locally and then save it within the project (you could create an /img folder within the Wireframe directory). This will make the code easier to read and maintain!
The <img> alt text is not descriptive enough. Here is a good resource to review: https://accessibility.huit.harvard.edu/describe-content-images
Wireframe/index.html
Outdated
|
|
||
| <article class="card"> | ||
| <div class="image"> | ||
| <img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAATYAAACiCAMAAAD84hF6AAACc1BMVEX///8AAACjo6OEhIT///0EsgH//v8Agf8Bg//+kgD///zT09P8//9aWloDsQL///nu7u4Ahf9VVVX///aVlZUeHh5bW1t6enrl5eUAtQCvr6/3///5+fmKiorv//9/cFhkcn4sLCwAlgD///CZkIGcnJyHj5fd3d3JyclMTEwYGBj//95jY2N1dXUAABMAhfu5ubkADQD//+sAbNsoKCg5OTkAGgAAEwAACADAwMAAigAAnADshQCAdF9VbX+CiJba9P4AbNDi//8AdNEAiPkAABkIGy9CQkIeXxwhiSQYrRQdmR8AHwDx/+0NAAD6lgDx1rL/9s70hADkigBvd4G51uy44O2x2+7L6fUldsgAZrMAV7MAXMx+sN+gyvSdzeo0ieMAbOdml8plmeF4ueI/gcZMkLlRisK/zeGXtdZ0kbxws+puoL2t5PwAYMoAVM5xx/bD+/8AdNqD2/t0st0bhNGYyd8AafWjx/eIye5SlusZd74TYaYAT6qWs8u+2OMAFTcLLloUP3UQMFgYUokQPmYADTQAJUgNNFAKGUuyuKkbWoQaTI0YaqYhVYMROlgYVmw0eKwJHSgLRQoMLwocax0OOgokfR4pJC8tnjQylDolayUlWydibmIcSR8NVAjC7MJ4pWvK89Gs6aVvt2ii6ZuS05hfu1h5z3ZbqFnC4MFSx0pY21eWypq00Ku59KfU/81t1WeDrIBbk1RDLh6TZSu3fjHQjioqFg2we0BrWSdUOhXnpjE5FAYiAgBzSh1SLRHXpljaj0TktX/Rr4PwxobpqkXw16Lqs2vfhSr79L3OmWTzznj1qFD5w1v//8TsqiFnRWZCAAAeoklEQVR4nO1di0Mbx5nfQcuCVxutYAVI6HEHKuUhZGzJ2AapVx6yMVIIEjpsEzuxcOzaPp/dloa0OfvSJLWbXFMnl9qY4rSNQ4hfOadOm1jphV4KGJAwxPmT7pvZlbSrBwgbY2H4xUHS7rfz+O33zXzf7MwsVVpfb7fby8rKVI8DZWX/GsM/Z4F/kSHxK3Y2llLZ4yrt0rUpKwOy6utLKZXKbNbpdFVVVXmPAVUEOt33Zfjh9zPhh3LEfkuXSEnoxLI+lsJmUxvI3mxWqahVAIcBf41GDv9g8C982IgPKoSIBEUTafG3Ufpss8D31SjskwdN0yzL0hja3n0WI2vcu6+FZ2mjkaEZfJTB1MEHSPG8cW9vi5Hdv6+3Db7u208xIMkKVoFlaIHd3/d8Cy9wHC0mx4p34ikFHUfLgYMvGI0vHjzQa+QFHtfayDIMw/McT3PwBY6CyAnK0u48eMjY1v7jE6CVQKqRB/Joluo92NoC0rx0FzDWA23GF5x9+9tC/YctRktLi4VljRYjw2AzNRotlhYLQ/OWvv6XjPudBc6T8NfZS4Fgm5HmjJY2OL+v/3QLNuEEayJtDPOk6/gYQMvUrdV55NDp0/sth472tb/UQrX86Nhx7sTRf+NePHr0ZPthI5juC/19baf6PQMhy6GDfS1tL/S19r1g4V45duxk67+fAtrafnTsNVmSJIenkrYEGOqQMxRqfcFy6MfOo+39fS37W/tfNL7c32f5RX9B6wEwSdrY62z/6cn+n/S17j3iPGw51t961Pnzw5ZXnf3O1hOn+lt/etLZup8YKU7w6TVRORjGMljYAHZ61Hmybd9A/6Gftve/aMH6daTf+XJvC0UzTEtf66mjp08dc/7s2MEX97a2H2o74mzf/8qA84Xetr3OgZ85W3spniWprRfaKIY75ex/lWppH9gnWI4OvIxpw9rW9iL8j3tc6BZeGvhZCHh0nvSc3v+Kc7CF29vaf+qV9lALwwJtA84jRoYiqrZ+aKOAMechrqW9HzrKwYEj+1t//gvLkZ/3WV4FQ6UpjgYujgx4Bg5zva0eZ1/bPrBY6pTz9N5XBgbbBGGfs+Gks70NOl3SEaw32iwv9YdO/cR5oBf4+49XQ0DZqwNn2iQK9g783HmIautr6H/J0tLnPHnqJdDEQ6B2LLuvtfXU4MHDFrEHWFe0PX+6l2L2n2k9ePrAK0bj4dPO0yEn0HbgrEWioO1o/4H9nOVw68EXjfSJ1tMHD7b2Gg8deL6FoXoP/GdL72noOojgeqLNePx4CwRWLYdOvPZLi4Vvee1E777Xei37jx+P0Wb5Ze9x8OvgiBaMdv9rL59ooYwtx4+bGMZ0/LjR2HvoODh69JOtxmpDjDOxquAY0yqQABVHV5xRDFElSJEniRGsVhy3QhSBT5g4/C3msa0TcCSM50R/laNxoCQFmLTYYOFQE74TwE8GiwgQhuJuAEfx0pl1RlvctRdjIsnYEh6/FPfHaSNHsJ4xWO9Y7KEwLI6o1hVrGUDH/5DPFEqIwyHqYSKi2kBWkIW2T7ooawkbtG1gA48XdPWWvKryJv2iQiZ1eV5eXo2WojK7GLS6XGc268qr14GtanXbkIiOLRnHFPX2OkmotIZi0/HGUKbyRhRL6Tf00z1AyVRBLV9/4803z7+1GaFtTWmFtCos9CsstAuhYjUei0wRqqlAaPevfgt4A4Q61NRTTJu2GG1+42wo5PF42vvOvY6QOY1QNajj+TNEKNT3218jVE6l0qYDYs8NYhkQwimVr0LxnxBMFWj32VBDQ0NRYVFhg6f93GZUnyKk3oneuhBqKCgqKmrwFHj63kAoL0UIWDs36IGEivA/T/ub6YSeEphq0e4zIU9hYUFhIVS2oTB0FiFdkpC2Dr0NStQgyhQUeULnENqSJLQFWPNAQoAiSK6gYOBdhNSrVY9VBUOp0Ot9DYW4mri2oCcNHuCtRilWiv5rkAhh2orwHw+okrLb1WLW4AwRKiQphs6jCu0q1mbVQOsROuspwJwVEkqwwoXeRR2ydoujatCu9oYGLFVEWMO8eN5CZYqkytBbIQ9YZ0GctsLC0O6n1EzN6I1Qg0iayBpulQYV6sZxxehce0GhxJpEiecC2ixXNy3mH7eQCdoKChrOoQrTqtfp8cO0jSibSAf5h9XNcx7ZZUJ6tLkP65pEWxH52hB6S9FRlqO3BwsLG+JGWkRoC72ebO9PBarR7r5CkTVCGyamobDgLGpMeFz0b9BbnqKYtolqBIx43lX0uHb0TgiOKmgDFs+ndC9PA5rQeyFwO4okLkgbB+o2uAvJmnIz+m0R5lY05ZggWGmHLKVa9L6H0CYTKyz0vJPGm1m70DflmfF0x2J03oP1S05bIdC2G+G5myJUFehsg+hVxKQIbX1oZ1kCJeiMh+itjNzCAuB2m0qla6p+0hVeAeirOlAcbwIjYJZy2oowbQpcIKZXIGMNaBvYrBQ6QzxdiTZJ1PO8dLJEtcY9OBJcltSbywFb7KBt2LSU2lYEtOVtgdMiasEhKyooVJBGtK2uPIGKuLYVyE35LKotL6+y4wC/lBC3RocyayC4rK+JeQU14P0XFhYVJexKNNLNyrbtfDJtcEFS21ZPuoTCIoVYQcO7onfHqPHNwsHu2qQN4sbiREPDQE8KUaSsrpg1j+d91Ji4hG5Cu8G3U5oo2B9mJNbfMpDw+RBp/RS0gb8bi8Gwlj+jXZu0mRGqkvufTAUoSQMJrRK0FYXek4+C0ODJXvAUiEKFMeD2LxGVMqC3rw8Wxc+SlhC66DPyEKymBHVoqTVImy4pAKepKlC3BnkHCSbrgcpWyydB2tF7g4VyzuBr6B20TREAdKA3QwnesAiEab/C/kc8IW0jql2FWq40ahBKHoPU1qFzoQYFbYXH3obKxh8gA9RY3QpF2sS+smHgKA435XNjmtDmC2T8Kc5dUejsZqSmZAnpK9CqrBZYUWhLUFXKwXK0+d2QxFgBCbNC/4126pUPkc3o12c8CeeiqKBh8G3UKChnFNnR7jMeT4MYHxCtPbsLjF0xwKtOvXE5DzOqTTNIbQdVIvpGBio9ocF3sSXTrHxyPB6Uez8U8hQRToqKBo6+hzaraeU8LDBBMnInBq0Qj17YBTbJMIrFCTp52LYmAPaYzuVkShF67ygeyYYY3hN6/23oNSg80yOxGIOhtB1o8zt4uBuPx3kG3/8dHoBUzmugKe020NyjITJ81BAaPLcZ1WqliUiJ3CpShjdzHHnombTHjd9HaNc7F84MDg4evfAewmZEpnMoqmuqR2g3FgoNnnkHYojfV1Opc/60ILTr3fcvnDlz5sJ7uxAqM1HJtEGjULziNXusqM14n2uwE79r9+9+h8Ol+mqRNbkAbtTL8eO+3QAspNJyXDonAoIFwGaEZRqbyJTKJHqhgV38YWyOwYRQ5gHqJrv4fLPDLPrC6TwrU3k9eZpaV5u3yEh3TVlHCQRvtWY1lX66ln1tWWnN4tZh0uv11dolmmuTvlqvX/LpgBaQ+Wze2vJBytM+/5SAtWtJ3x1slyIT3Jb08Rdjv4aMwK2ZGKtq8ach2VYizbTA5UFNIoU1Q5tuBZ6Rr0RF9aiCWlO0Pfqztw3aHgYrUlGgbQ2wFUcO0baWwqscom2dadtKtG000MauoXULOUQbv85oWwGsR21bCRDa1g42aHso5BBtT7oIy8EGbQ+FDdoeChu0PRTMG7Q9DOw5srhCj0qedBEkZBUaF+fILNpFn2lQWVbmEa4xqctVdrtuS3Yz/7V1WT8x0jZVldlV4kq+jNBv0dlBqHr5E8E7Mt4/fR5+yFNXWlWNecgykiDxXnU5lMZcvnRptLqK2DTG4ibT0kvpahSz0RYpQ009is+ATE80Q3FbamNCjVXLXbBhzvBQozqeMa4Sl2X4SzM0W551acqfQ+jZi3v2fLDn0g7FlLVMsGc3ZRs/Id56CRLec/ESnsiXpuwcp4Zi7riMM7+8HbRjmQ/w1ElTlSToILtLezo7RzqHLm9FyK7NzvQ4St2IS/MhLjKUpmTLInpqR+jysEuD4fV9sBUvv1g8E23yWp/0UP8e7bzY6dLk43Q7gbji5LtHk8VV2z/weQ1EaBiEVMsLzTvSdU5wu3DGBo0mP9/r27MTdSz19FFCOZRmj1QaFy6yOaOe1qOdQ15IH0Q1BoNm5PKSE3lUWUx0p/GEoMs+Ly45uSO+4a1g2vJS4JGjJqggLiaBwevag1AZuxzetqDGJHWjsR4M4YyBNrhn+d7OHagjq2YTWPvTiDdf5ELj9Q5lvosqtKMz35BvMJCyawz5votkIl9mqJc4L0K7DV2uNOBkNSK8ndtRvYI2Dif1Bx9WCpK9Aao4jCfbLKcza0xp3XRo67B4J8SMDQbfdmRfcjNaPIkT7fFqDPFLDZqhTMtYQXSY3GksLWrGyKUM82JEaLObjmdHl3waMVURQMlWRSFoju9Al4kRSyXACgIl1S+HtqbkBZN6hD7Q4JsQ4w3S7UxZZ5gGpgr0J6+kPtKVoG/PpW2PatFFL7nTcdryNVd2xsw0zQisqTYrja9GqBObflzbvPka7x5UYZItJKLy0A6fRBqRxN9B2Ze31sWcxFsZuuw1aCSlIQSA9e/Jou+vQltHNImrxFJfVqwYi0GNtldKBMcuMORDJrXYUOiU2UKga7VoWzb9gR1uR768CPjTtVMx1cXUgYZkGUuSnVm1AYqs5KoEHnAn1nKolCE/Vi+NbyskuujzVMZUAqUxGJRlNvjSOtRm9KHXICu3mM0VsatMpo0mKxEas6kUOMSdXkWymDe4H3JNUqOtvnzRnCReiWFcTDO9NS1I4WjSceriBrAFGoc4ZfGsIVHdEvPKm9COEU2cN5E2gwHULU34XYuGk1jDxPkuEa1IyQY7kSleRFrU4JZNMj9N3FZAk0pkBp6HzQk3aDLaoKTDizatMsQLB25aY0yNzdCsSy2bmLPYlw+j0iVo00HLptR7fLlhKGmFMIa2ZIfPkMghRpv3D6n+rElf/gy4o1mG8HlojyaWs0yPwVZkrKvQkEZx08gFGt/yl9uqOxCq0KlNJqx6wzG3QJazoVO+qCQt6qEnUdAg0uKDVjF5g0ct2u6Suhy5MBjTtmeKi5+Jobi4Q4q+autlhzOjtBEY0eQn0ZafD55AbWmxhPoSNKxR1FBkGpqTuEyWKJViqbrG4jrRM0imDW5Y2oLGUVxCaFPea2gz4CampU3qqJNoe2QMaSTlkZMCtCmQSls+oe2RkIa2fEzbkshEW8re+TFtU9KGjdRerVbDv4dEtQpdTCkD7tC2o6a4kL6edF3J2gZmURITqdlShie0mpfOMFZWfWl6bQMjrZaLg9uCKsrKaxLHioG2ZPMA2uDClPnY4OH50tF26VFHb6E/82ryU2lDSNZs6YjPKONNlO9UrgpqKkaoI3uXRAe+QRrahhV9uB6a6doaZQuqwiFCCm24L0mdxm7HNzyFNuLlPBL0aKdP4iFRhnwIAeReZxN61pdKm/fD5CikqYJM1M8u5xpINIU2jeaiXBFq8NTz5FCkHF1ySc2EvEAX0432YK3IV9CmIQyj7MqYGbW4T0jqFDSgxXKXDDt3OIqQVw984mdThmBM9mXwBn2CvOrxbiahW8BavUkcEpKlqcd+srJdwRHhjnQaZNqMm2WFIWm8vkvLDKfToBxt9+XLacPeU2eSy03ioHxl7qCRjakjpSpxpUw2qAKtMeSLnZEmESP9Md4fQtxXRplSQ4Y/YhWS06YhpUm7jjAPG4qy84AOoSTLcb1FUIHjD3kZvPh2KM1Pj0d4kroEH16llTrAXIbLlBW024jDq0moGo7IQWck2uA8DjNTaQM6h72ydoVEejvTjwEIHeiyT2nOw3i05JE3matBxExltLkuom2KquNYHg3LeMNR0CVw5xV5iyEU25H1EoQtePzHkKDN64XKV8V3JVeJI3RpAlQz2jGcKDIeOXFdQn9Mr+P6EnRpJD/W68XG5phH35uvCpdeZie+yxDpJq0jwmH4sEGTwMizqFErH3iJ102d3ZAyJe68d9EnJWiAjIewVcZewaPPPFJA1+O7CEUVhziha3w2jfchoboOSHYZDOKNGfkTQnZ6Rd65Au3RxWavNHDkHX4WD1Qkx4Q08PYhHgMmmbuGd6IKvWKZVmw4gQYztWfXchAl3j4kperqhNulEpfLiaVKNxIkwlRKBpsJb/le19AO1Jj5VunBMbo01Onz+TqHLoIzXUXTK6FtZIwZXR7yVeKEoeyN1WlCaQ78zq0XhyFz3/CHl6CL01JJtMWuqUZ1Wa9Lw1tGPHtxaHh4CKdZV06SIbSZFh2WYlWkNISLD7eTDjfz+wZocS2dCHu2PdZSYGhKX5ZItySPTpnmjF+mRqmfwad37sR/O7bQyQMviR/Fy1iXZsqLV2mbTiubYN2EahcdJ6gpJqUhoVjtUoujTTUkiKkrziPjbFmXbklo8+rrSBjTZBIf3iqUWHppXbWuFgs1qtQmKnW9VvxHXpohnMwwVZeX1T9jz1ObWJpKPPpRLTqYR54u62rxLewwq5lsGgVGu/K7o5HSmjImzCVeMWfScuIFmcfE1A+3FYMyudpFt2qMSWq12akOsyKNWWox6EWf3slfzCd+W4w2U/pHyYvnn5SctmLxSSPSRdnPflhmgbLE4os2YrQxFBX7ttjNQ3XL35wyqQDaumzSePILuBYtgEQb1vT4t0V4W2J6UYb8FQXQZhVsZHpKQ8qW+JPlZSsOkTYmThuz8rQlITvaMkHq0ziOTlNMjuNXedZ6ls3qE6aNZoWuri78OlD4ENIIrPYrpdYGbRR7tdPX+RnFdMHHR1blOYYeHRWedIuYHk+cto8rva4xjrnj0rjGjDiAAKLIG1Qpjh7t7LxK8SJxDAvn2FXXvgx40rTRnwBtnV3cJy6Dd8w4em3s+thVi7Hr2vXrY5+N3vC6bnzWZRzFBwX+9ti1sZu3HrW0K4MnTRv3SeWnnzbf6rru+p/Km11/ba50VTZ/1jXW7PI1D99p1miah0evNjf7Kptvg4i3svlquvcZrD5ygLbrNypv36n0fe662fXZtT//+VPXzTs+7+d3/ny764bXe+P26JXKG3c+994cvQ66d3uUz4k1/DlA281Pmm8CeZ+7rnTxV6+N+Vw3bdddrivX7lB3XL5R/k6l6/rYiOvK6HXX9S6jxbhBG4C7UXkTVO3T5o9vVF7put3cfB20revOjZHKyuGuq5WYtmbv9bGxa2CklWMCJ72l/FHL/KjIBdpGP3W5fHduuEZGRypvgFKNdN0aHf3E1Xzrqqvy41ujPteN0dGrt6zXXWM8kyMbbeQAbWPCWCUY6LXKkdGblb4Rn7fydqfL6wVtG4UOYhhOuFyu5r8INyvHcqNho3KAtts3/9I1evvaZ/ytmx91dd0c+ejOzSuj166PjIyN0vzH10f+2iXA35GPbvG3b97eoE0CBFX47alGmuEEgWGsXTwDwRaOuLoEVrB2dfEsKzjgF2OCI1xukLZCtD3CqyqkQS4SxuOXrGJepJHjmGKJrRmTxUZhq4dtjzozBT/HWWp24NOH+iU3jM08/i6haa3tZrkC0C222R7et7GjpG5bh71pEep0a2t7wRVBTSYL43lKK3u2uNWcsQ3MvJDy6YWpIsNjJ1aoqUPoiy/vhsPhu19+hVBFhkawGqG1tAPXCsGM7OkH7KuAtL/NBDcBurtn/vZVptV2ZYua+dMKfYYX0pUj9L/j3Zu6N4m8dYe/Tr/Gqnq5C2yeEqjSrvcCNr4Z7xZJEzH+dVq3tnZZz/WfHkDrlqbitejrmW4Fbd0zX6SZn6RSrMFZT1CneeNpE0Lh7m4Fb93dd8Eek2jTyS03VyKfVQGDp0qWJalMKfrmO6WyAW/ffY3MStpUsreJ5EqUvXoA3moV7bq+Dt1NYW0TqJviZQr6WvlC5HRLPp9yVJcgZJcRp0ZfxHvRBG2bws/JptRX2xHaJuuEc2P8cHVB3klWXNVUrSUoR1+Pb0pF8CukJuf1NVV4aw+7wrTpbHYzf9pQLUZSdQQ7wftIR9sX0nkiqkr219YdZwSmGnNxY4lE29ffpadN5K2i2FyzTv2OtDCZsA2aMhjpeMxINyhLi2r0Vbg7hbXuMEI5MgcjN2HaBg5IKm131+GA5LJQBlaawtv433NkZ76chR5hfzdF2Uq0zLrzzZYBBtTtq5kkdzf8fyiPWneRwPJgakR/DyezVroOA89lohqhL8LxMZDu7rtfSesEN2hbFOoKhL4Jf0eGj4LhbyDa167HYY5lQw+x+nP/+ObLu19+84/nIJYyUcwGbdmgpjSxSLFaXNi5QVs2wNvQ1pfhTXCZDbY2sIHcQI7M8lxreAja5MJLrIxbK7cDz6cjn9lfkEKbuJGAOGSURAmWU3YWi9K2lrSY5rJ4t+kiYGjOiF02jqPZZEp4I8PIko6vrKZ5PqkQRjxxcu1Yv7SulHmE8UX8UmsWkiCUJW+eAf/FD8lJTVZLGsuu9urQhwfHWR0sy8arkbTVivSZYlcKMcFhtVoFQXD4/azyPO3wBxJ6xYCSCQLP8hhWK61I1er3+61L7gudE6Ap3uqfmJy8P+WQXoROFgljW+Fxq8cKmE+wLIYmqkI0ChSL5Wmoe2xVmOP+5ATgnm0qOCEw8Q0OcCqOu8FoQPzFMpRwb+KeAzKcmLVa/ZAn6DhHi3tf0JwtHJwWWH4tWCmw44/29Ljd7inBKDY3MRUQ1UbkAConbUbA0HEzIm9YxzZI+YM4hZ7wXMQ94xBP4psAH4J1Nuie5aVDtDXiXrAJkaB7xuaArw7Sk0j7RNCOsHsajHQttG40w0+5g/Oz85FZgbf5Z2cDDqM14A/ANytYnIPl4NeU3yGw1sDs9KwDTMsPZ+/5WQYscmo2gEnmgbZvp6fhdMQ9brP6QTBg4qz+e/f8DsaxEJy1+aem/Q6O4/npTcE5W7gH/432RAQrPiFwAk7THwhvmseZWnOfN5pip3qC0wGbzco4JqNBd3SKD4Sj0WAwGAm7gxM21h8GVZoM8LPhoBs+QXuCC1F31M8HJkHDJrFyCX63e94WsAkCaJvNH3UHg2GHYyroBkWz3Q9GApNRN06YY9m5oHtuLtgNJwLRnlnr/WiPOzhlBYGFYHQOaLPdx0nm/JxVaLGg/O5oZNbKA3/zMz1RfyDYMz4T3BRcWOgGRYn2fDsf7JkOhN0L80H3fce0G5/ombJN9IzPj7vvCwzFz4I0tI8O64R7ITDZMzM/P2WbBSX+Ftq1e9PQ4gXnsTqDQdrC7tlp97cL7gicfzAFdM/0EArd4xMPwj3zETeQSXrmlA1kcwzW2QVQG/c9IAZUZtwdmQv2zD6Y2TTzYC4YnJ3tcc/PjwcjwNacdbonGsBfHoDoHDbMmZ4JK0Vo6yaqGAkuBCI9wciszTbhHp+ed0cDVoGZDfYsTM/ZBGjvoHH7dsY9PRtc+NY9MxfumbY9mIG0wGADDqB0Bgh2CIoNhXITNHgDjsA0VAzsZ1ZwLPRE8BdbZNOELRAOgmpsCkaD0alIT9gB9Q/PzbuDAeBkHqiKToajEagkC9/nZ6E1xNpm88+ANd8Hi3NPRqMLAZ5mHNNwJDoLeskCw999FwSFDo67pwPB7mmrYwKyBh20CrZwdzc0ejyzBmhjeWjfbXMz0A2CotnAXKYfAG2gFUBbFGtb9/yDB3MOaNL8jkhPdG4+GLQ5JoHcaM98AE5gLwXMej4AwL2j1RGYm+/pmV0AdQ0E/CxomwmOjAOhPMtygfHu7hmbdQYICoA9RxyBMGhaFHpbxhHe9C2Ugedyum0TO3oW96ThqBvKTlotMCtQBdwnzhDaAgvu8ERkErq5nigYc8Q2jbVtBuo75Y5OTEzeAx2i/W5oHqPhycBEcMZ2fzKCUwHHYyGC2zuW8U9GIjPuCHTDrFFY6NkUcQigxAs2MHr35CT0BbhZ4BloRueh+Zy2LlXyJwqJNta/EAy6xyM23jYNHd7MnNURDs/yU+EpR2By0i8EIsFgdNLvmIPuMDhvE6aCYZt1IjhttUWgQ5308wzH+yeD48FwcDIwHY0E7uNuE4xvOgwXTlnB1fNDFz0eCbAs+MfQI4f9POUPQ/q8dTrsdi/M4p40INDWieiULRKctOWufSYGMWjBEQjMBRy0SQAXze/gOd7hsNIOm0OwOsBfg5YPmx/8gA8ry1ptNqhhwGYlB2wCXs5ptQUIHDZ8PDAHyVkF6TpQMcEWmIVL4RaxvIATNjE4DwGnM+uHTsPhAEGBx6cc4AoR2nJ6TA/KBjoAcSKLYyUIlngJAg4eAXwCeJhEOocJ4MlKYSKFtYgnyQhWnmHJheTpPE4cS4IIjeNe/IcVs0okLyaAx0ZI3CHu5EZ2CqBUKrNZp9NVVVXl5QqqJHwPyvW9XIPZrFKVlVGl9fV2u72srEyVQ4Di/CCOf3ps+EEKlpa019fXlxb/P7U6Jgf3ogYqAAAAAElFTkSuQmCC" alt="Article image" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The <img> src is very long and it makes your HTML hard to scan. Would it be possible for you to download the image locally and then save it within the project (you could create an /img folder within the Wireframe directory). This will make the code easier to read and maintain!
The <img> alt text is not descriptive enough. Here is a good resource to review: https://accessibility.huit.harvard.edu/describe-content-images
Wireframe/index.html
Outdated
| <!-- Featured Article --> | ||
| <article class="featured"> | ||
| <div class="image"> | ||
| <img src="https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcQDwKkSvUlpzg1aNUKH0W96vfQPAdV4okepEw&s" alt="Article image" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The <img> alt text is not descriptive enough. Here is a good resource to review: https://accessibility.huit.harvard.edu/describe-content-images
|
Hi @jenny-alexander Shuheda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some good adjustments were made.
- Read More links:
I see you added a border around the Read more link so it looks more like a button. However, now there isn't enough padding around the words and it looks very squishy.
The original styling of the button seems like it would be good to use.
🤔 Perhaps you can revert to this?
a {
padding: var(--space);
border: var(--line);
max-width: fit-content;
}
- The footer is now fixed in place👍
There is a slight issue with being able to see the footer text when I scroll. If you add a background color to your footer, you will be able to see it better.
In this video, I show how if you make the background color white and add a border-top (in CSS), it's much clearer. Can you try something similar?
Screen.Recording.2026-01-22.at.11.18.01.PM.mov
| <article class="card"> | ||
| <div class="image"> | ||
| <img | ||
| src="WireframeImage.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The <img> filename is incorrect here. Can you review it? They are case-sensitive.
| margin-top: 1rem; | ||
| padding: 1rem; | ||
| text-align: center; | ||
| border-top: 1px solid white 000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you review the border-top? I am not sure the value '000' is.
|
|
||
|
|
||
| /* Footer */ | ||
| .footer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two footer classes defined. It's easier to maintain and avoid conflicts if only one footer class is defined.
|
@codebyshay Don't forget to change the label to 'Needs Review' once you make your changes and want it reviewed again! |
|
@jenny-alexander yes! Thank you for the reminder :) |

Learners, PR Template
Self checklist
Changelist
I completed Wireframe with 100 accessibility score on Lighthouse
PR template completed and ready for review